chore: add tests for connecting with a profile from an aws credentials file MONGOSH-1609 #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Nov 9, 2023
| @@ -220,6 +221,7 @@ async function main() { | |||
| }); | |||
| } catch (e: any) { | |||
| console.error(`${e?.name}: ${e?.message}`); | |||
| console.error('full error: ' + util.inspect(e, { depth: null })); | |||
There was a problem hiding this comment.
Leftover? (Fwiw, I do this a ton too…)
There was a problem hiding this comment.
yeah. There's nothing more there anyway ;) Hoped there would at least be an original error or something..
There was a problem hiding this comment.
Would be nice if we could access the most recent error from the test somehow.
| const awsConfigPath = path.join( | ||
| os.tmpdir(), | ||
| `aws-config-${new Date().getTime()}-${Math.random()}` | ||
| ); |
There was a problem hiding this comment.
useTmpdir() from ./repl-helpers.ts?
There was a problem hiding this comment.
Didn't know about that. copy/pasted this from another test.
|
Blocked on https://jira.mongodb.org/browse/NODE-5747 |
|
I suppose we can always re-open this if we ever need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.